[mythtv] [mythtv-commits] mythtv commit: r15160 by nigel

Daniel Kristjansson danielk at cuymedia.net
Fri Dec 14 14:48:55 UTC 2007


On Fri, 2007-12-14 at 07:14 +0000, mythtv at cvs.mythtv.org wrote:
> Author: nigel
>         Date: 2007-12-14 07:14:05 +0000 (Fri, 14 Dec 2007)
> New Revision: 15160
>    Changeset: http://cvs.mythtv.org/trac/changeset/15160
> 
> Modified:
> 
>    trunk/mythtv/libs/libmythtv/libmythtv.pro
> 
> Log:
> 
> dtvchannel.cpp hasn't been compiled since it was added in [11691].
> A test build hasn't revealed any breakage, but I am amused
> that it's code hasn't been used for the last year.
> I guess it is always over-ridden in base classes?

Nope, it looks like qmake on Linux was being too smart for it's
own good and it was compiling and linking dtvchannel.{cpp,o}
despite dtvchannel.h being the file listed in the sources.

I was shocked when I read this commit message, because there is
some essential code in dtvchannel.cpp. So first I confirmed the
libmythtv.pro problem, then verified that the code I thought was
there was really in dtvchannel.cpp and wasn't overridden, and 
then I noticed that dtvchannel.o was there in libs/libmythtv
despite the libmythtv.pro problem...

-- Daniel



More information about the mythtv-dev mailing list