[mythtv] [mythtv-commits] mythtv commit: r13697 by janne

Janne Grunau janne-mythtv at grunau.be
Fri Jun 15 20:14:42 UTC 2007


On Friday 15 June 2007 20:55:35 Anduin Withers wrote:
> > fix extra-cflags and check the user input
>
> Currently it will only function as if it were --extra-cflag; options
> passed in are kept as a single word through the whole checking chain.
> The same is true for --extra-cxxflags.

Fixed.

> Line 1668 (echo "# $0 $@" >$logfile) being where it is, well, doesn't
> make for the easiest log (you lose everything that is in the log up
> to that point, naturally). While not regression related to
> EC(XX)FLAGS  (as ECFLAGS checking was incidental prior to the recent
> sync, and ECXXFLAGS was simply not checked) it is icky.

The cleanest solution I can think of is to log first to a temp file and 
write the contents of that to the real logfile after we processed line 
1668.

Janne


More information about the mythtv-dev mailing list