[mythtv] [mythtv-commits] Ticket #3196: Autoexpire and backend fail to heed maxnewest = 0, deletes old programs that shouldn't and records new ones

Chris Pinkham cpinkham at bc2va.org
Mon Mar 12 21:52:20 UTC 2007


* On Mon Mar 12, 2007 at 09:23:24PM -0000, MythTV wrote:
> #3196: Autoexpire and backend fail to heed maxnewest = 0, deletes old programs
> that shouldn't and records new ones

> Comment(by subbyz):

>  After looking through the 0.20 source, it appears that
>  AutoExpire::ExpireEpisodesOverMax is not testing maxnewest > 0 in it's
>  checks.
>      query.prepare("SELECT recordid, maxepisodes, title "
>                    "FROM record WHERE maxepisodes > 0 "
>                    "ORDER BY recordid ASC, maxepisodes DESC");

We don't check maxnewest here because the expirer isn't in charge of
what gets recorded, it just deletes the oldest (or whatever the expire
sort order is set to).  The scheduler is the one that is in charge of
whether we record new episodes.  There is a bug in the scheduler's
maxepisodes logic, it is not checking the recordid of the rule against
the recordid of the existing programs.  maxepisodes used to look at
the program title, now it looks at the recordid, but the scheduler was
never changed to take this into account.  I looked at this when you
submitted your ticket and verified, but didn't make any comments about
it, I just moved it into my view because I know what the fix is.

--
Chris


More information about the mythtv-dev mailing list