[mythtv] [mythtv-commits] Ticket #3823: flags commercials on channels set not to include commercials
Michael T. Dean
mtdean at thirdcontact.com
Thu Apr 24 17:56:30 UTC 2008
On 04/24/2008 01:45 PM, Kevin Kuphal wrote:
> On Thu, Apr 24, 2008 at 12:27 PM, MythTV <mythtv at cvs.mythtv.org> wrote:
>> #3823: flags commercials on channels set not to include commercials
>> Comment(by sphery):
>> The issue is due to improper configuration of the channels. The reporter
>> most likely used MythWeb's channel editor to set the commfree field.
>> Since commfree is deprecated by commmethod, this does absolutely nothing.
>> Since MythWeb has not yet been updated to use commmethod, the proper fix
>> is to use mythtv-setup to set the commercial detection method to
>> "Commercial Free" for each channel, as required.
> Not having looked closely at this but thinking off the top of my head, is
> the commfree boolean a column? Should we simply drop that column from the
> database so that this behavior generates a more obvious error rather than
> silently setting an unused variable? Other 3rd party programs may have the
> same issue and leaving the unused column just makes it seem like it is still
Janne already dropped the commfree column from trunk with the database
changes required for the Qt4 port. See,
http://svn.mythtv.org/trac/ticket/5195 . Removing it from -fixes would
be much more difficult at this point (because the DBSchemaVer for -fixes
and trunk are different). The right fix is to fix MythWeb, as mentioned
Sorry. I should have mentioned that ticket in my "follow-up" comment to
We could easily just remove the commfree column from the channel editor
in MythWeb or we could modify it to include a drop-down list of
commercial detection methods (with values as in CommercialSkipMethod in
programs/mythfrontend/globalsettings.cpp and CommMethod in
libs/libmythtv/channelsettings.cpp ). Or, we could leave the commfree
column as a checkbox (but set the commmethod to -2 when checked) to
retain the "ease of use" of the boolean. If we leave the checkbox and
update the DB appropriately, we could also (optionally) add a drop-down
with commercial detection method that includes all except commercial free.
If you have any preferences, kormoc, I might be able to do up a patch.
Thinking about it, I may take the last approach--just update the page so
the checkbox sets the right value. Then, we can add the commercial
detection method drop down later, if desired.
More information about the mythtv-dev