[mythtv] [mythtv-commits] mythtv commit: r17896 by kkuphal

[Nigel Pearson]

> -    QHttpRequestHeader header("GET", url.path() + url.encodedQuery 
> ());
> +    QHttpRequestHeader header("GET", url.toEncoded());
>
>
> Kevin, can you explain the original fault a little more?
>
> Basically, requests to Google using the Google Video RSS feeds in  
> MythNews would fail to download the thumbnail without that change.   
> I'm on QT4.4


It took a while to get a working test rig
(at work, my machines are firewalled),
but I think I have a more correct patch.

Can you (everyone) try this:


Index: httpcomms.cpp
===================================================================
--- httpcomms.cpp       (revision 18042)
+++ httpcomms.cpp       (working copy)
@@ -67,7 +67,12 @@

  void HttpComms::request(QUrl &url, int timeoutms, bool allowGzip)
  {
-    QHttpRequestHeader header("GET", url.toEncoded());
+    QString path = url.path();
+
+    if (url.hasQuery())
+        path += "?" + url.encodedQuery();
+
+    QHttpRequestHeader header("GET", path);
      QString userAgent = "Mozilla/9.876 (X11; U; Linux 2.2.12-20  
i686, en) "
                          "Gecko/25250101 Netscape/5.432b1";

--
Nigel Pearson, nigel at ind.tansu.com.au|"People say I'm strange,
Telstra Net. Eng., Sydney, Australia | does it make me a stranger?
Office: 9202 3900    Fax:  9261 3912 | My best friend was born...
Mobile: 0408 664435  Home: 9792 6998 |     in a manger"   -DC Talk