[mythtv] Re: [mythtv-commits] Ticket #4593: /.mythtv/ should *not*get created (blank homedir)

[Andrei Tanas]

<FDB1D302-DFA4-475C-9411-E6F3D33D0D7B at ind.tansu.com.au> <47A8EE92.7090206 at thirdcontact.com>
Message-ID: <f4c60480d1754ca14d8fbbc4b01467c5 at localhost>
X-Sender: andrei at tanas.ca
User-Agent: RoundCube Webmail/0.1b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit



On Wed, 6 Feb 2008 10:56:32 +1100, Nigel Pearson <nigel at ind.tansu.com.au>
wrote:
>> On Windows HOME is usually not set
> 
> Well, a MinGW shell sets it, but an XP DOS 'cmd' doesn't.
> It seems to set all of USERPROFILE, HOMEDRIVE, and HOMEPATH.
...
> Qt seems to use all three:

> so I don't think we will need a patch, or a check, on XP?

libmythdvdnav/remap.c, lines 192 and 193:

  home = getenv("HOME"); assert(home);
  strncpy(fname, home, sizeof(fname));

It will segfault if we don't set HOME or not patch it here.
I don't think trying to explain an average Windows user that they need to
set HOME environment variable is really an option.
I'll submit a patch tomorrow (don't have my laptop here), it's about 5
lines of code.