[mythtv] [mythtv-commits] Ticket #1104: multi channel audio support
mark at digivation.com.au
Thu Feb 14 01:15:13 UTC 2008
> Mark, thanks for the win patch. Daniel, it wasn't quite right (it changed
> the sig of Reconfigure to a bool for audio_passthru, and didn't cast the
> second arg of swab(). I will commit re-repair soon.
> Mark, audiooutputdigitalencoder.cpp has a lot of (data+8). Any objection
> to this change:
the swab is doing the byte swap in place. the 2nd param is not a const so
didnt need to be typecast.
or do you mean to change the type to char* and const char* instead?
the main problem in the error I saw as the non constness of the first param
which if the compiler is a bit more strict, it will reject. I didnt think
there would be a problem with the compiler implicitly converting uchar* to
however it wont affect linux systems as the libs currently have swab defined
an alternate fix could be to fix the header in mingw where swab is defined
to use void* instead of char* (string.h I think).
This may or may not be desirable and am not sure if andrei or buzz would
like this to happen.
Either way I dont really care :-)
More information about the mythtv-dev