[mythtv] Shoutcast patch ; updated for svn 16380.

[Otto Kolsi]

Eskil Heyn Olsen wrote:
>> - Patch requires "Show entire music tree" option to be on, this is 
>> problem IMHO
> 
> Guess that's an artifact of me always using that view. I'll look into
> fixing that.

That sounds really good :)

>> - Arrow in MythMusic entire music tree indicating currently selected 
>> item is not moving in up-down direction. This might be general Myth 
>> and/or Metallurgy issue
> 
> You could try another theme for a short moment just to verify :)

Yeah.. I moved from trunk back to 0.21-fixes just to be able to do some 
more testing with this patch. This 'item not moving' issue does not 
occur e.g. with MythCenter so I think it isn't shoutcast patch issue. I 
didn't notice it earlier with Metallurgy since I don't use the "entire 
music tree" option normally and it probably is somehow related to that.

>> - With shoutcast streams, visualizations are not always working
> 
> This I'd like to hear more about. Which visualisations ? Any pattern to
> it ? Anything that's reproducible ?

I think normally every visualizer that I use work also with shoutcast 
streams. But then if there is a 'decoder error' dialog (don't remember 
the exact text), after that some of the visualizers stop working.

It feels like because of that decoder error, something gets to a state 
that breaks some of the visualizers. For example, one time when this 
happened "Goom" and "Synaesthesia" stopped working while all the others 
  worked fine. And cycling the visualizers doesn't help, when they break 
they just don't work anymore. I'm not saying this affects only these two 
visualizers, just that I had one occation with these two. I think if you 
re-start MythMusic, everything works again as expected.

> The other benefit of this being in svn is that you could file tickets
> instead of relying on my memory. 

Yes, it would be much easier that way..

Now with more extensive testing, I've manage to get some segfaults. I 
started to collect backtraces and I think first 4 that I got, are the 
same issue related to AlbumArt and Decoder::getFilename(). The fifth was 
SIGABRT elsewhere. I've attach two of those backtraces to this mail.
-- 
   Otto
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shoutcast-gdb1.txt.gz
Type: application/x-gzip
Size: 3238 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20080322/cafc09af/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shoutcast-gdb5.txt.gz
Type: application/x-gzip
Size: 3038 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20080322/cafc09af/attachment-0001.bin