[mythtv] [mythtv-commits] mythtv commit: r15381 by nigel

Chris Pinkham cpinkham at bc2va.org
Thu Mar 27 09:43:34 UTC 2008


* On Thu Mar 27, 2008 at 05:01:45PM +1100, Nigel Pearson wrote:
> True, and worth doing, but I have recently
> started being careful about reducing bloat.
> Having a lot of "programmer debug" verbosity
> will just slow MythTV down for most users.

We could leave out these extra calls for non-debug builds by putting
an #ifdef inside the VERBOSE macro.

> > We could create a new VB_EXTRA and remove this bit from the VB_MOST
> > mask.  It would work just like VB_TIMESTAMP does now.
> 
> Just committed, in [16814].

Saw it, great.

> Note that VB_BLAH+VB_EXTRA is probably clearer, meaning-wise?

Yeah, I debated replying to the commit email, then came to the same
conclusion that "+" makes more sense than "|".  Probably would make
sense to switch the VB_TIMESTAMP messages to the same since I think
they use "|" now.

--
Chris


More information about the mythtv-dev mailing list