[mythtv] Ticket #4872: Detect if video is letterboxed and switch to corect fill mode

[Mårten Bohlin]

On Thu, Mar 27, 2008 at 1:16 PM, Ben Dailey <ben at inspiredtechs.com> wrote:
>
> On Wed, Mar 26, 2008 at 6:42 AM, Mårten Bohlin <mabo at mochc.net> wrote:
>
>
> >
> > On Wed, Mar 26, 2008 at 10:33 AM, Robin Neatherway <robthebob at gmail.com>
> wrote:
> > > >  Does anybody has any suggestion of any other issue that I could have
> a
> > >  >  look at now?
> > >
> > >  I'm using the patch now and it works well for me. The only thing I'm
> > >  not clear on is whether any DB configuration is still required or
> > >  suggested to set the trigger threshold?
> > >
> > >  Robin
> >
> > It is still possible to set it in the DB, but I have updated the
> > default value so I hope that it will work for everybody now. The
> > default value is now 75.
> >
> > So I would appreciate if you could try to use the default value and
> > report if there is any issues with that.
> >
> > Mårten
>
> Mårten,
>
> I have spent just a few moments working on updating your patch so it could
> be used to detect pillar boxing. I get my stations via OTA in HD. I only
> have an SD TV though, I don't mind watching HD shows letterboxed, but I find
> it annoying when a SD program is pillarboxed by the network and I have
> letter boxing on because the source video is wide screen, so I end up
> watching some shows inside a black frame. Would others find pillar box
> detecting helpful? Is this a feature you would like to see added? Also in
> the very start of a patch that is attached would it be best to set the
> screen aspect ratio in an option or to do the detect it with
> GetDisplayAspect() as I am doing now? Be warned I think this patch breaks
> playback but I wanted to get comments on whether this is even the correct
> direction to start in as this is my first attempt at a patch for myth. Also
> I would appreciate and recommendentions, critisisms, or suggestions. I will
> attempt to free up somemore time to work on this if people would find it
> useful.
>
> Thank You,
> Ben

Hi Ben!

Since you have the pillarbox problem there is probably others that
have it to. But personally I do not, that is why it is not included in
my patch.

Which version of my patch are you basing your work on? In version 6
there was a fix to not base the source aspect on width/height. I am
now using the variable video_aspect instead and I noticed that it was
not the case in your patch. I think version 6 is the best for you to
work on since it still have the debug drawing in it.

I think it should be OK to call GetDisplayAspect() each time. But I
have not checked what it is doing.

Mårten