[mythtv] Ticket #6438: maxEpisodes is not respected with back-to-back recordings

[Shane]

On Thu, Apr 9, 2009 at 3:04 PM, MythTV <mythtv at cvs.mythtv.org> wrote:
> #6438: maxEpisodes is not respected with back-to-back recordings
> ---------------------------------+------------------------------------------
>  Reporter:  gnome42              |        Owner:  gnome42
>     Type:  defect               |       Status:  assigned
>  Priority:  minor                |    Milestone:  0.22
> Component:  MythTV - Scheduling  |      Version:  head
>  Severity:  medium               |   Resolution:
>  Mlocked:  0                    |
> ---------------------------------+------------------------------------------
>
> Comment(by gigem):
>
>  Replying to [ticket:6438 gnome42]:
>  > The attached patch corrects this by adjusting the query to count
>  > in progress recordings in the max episodes count.
>  >
>  > It looks safe and does the job but I could be missing something so
>  > I'm posting here for further review.
>
>  I think a better fix is to simply drop the "AND duplicate <> 0" clause.
>  That was added in [15808] and is the cause of this regression.  The issue
>  of whether or not a "forgotten" program should count towards max-episodes
>  can be handled separately if needed.  IMHO, the forgotten program
>  shouldn't be given any special treatment.

Thanks for the review and comment!

OK, dropping the "AND duplicate <> 0" sounds like it would fix this particular
issue.

I guess the remaining question is how does that effect the "Forget
Previous" case
mentioned in the [15808] changelog.

Quoting Mr. Pinkham's changelog from [15808]:

Add a menu option to allow the user to tell Myth to forget that it recorded a
particular recording so that it can be rerecorded even if it is a duplicate.

The 'forgotten' program also no longer counts in the maxepisodes count for
the scheduled recording so that it may be rerecorded.

This is useful when you have a bad recording of a program and want to give
Myth a chance to record a new copy without having to delete the old one first.

End quote.


So, if the "AND duplicate <> 0" clause is dropped and the user hits
"Forget Previous",
the forgotten program will be marked rsTooMany and will not be rescheduled?

Shane