[mythtv] Ticket #6438: maxEpisodes is not respected with back-to-back recordings

[Shane]

On Sat, Apr 11, 2009 at 2:29 PM, Chris Pinkham <cpinkham at bc2va.org> wrote:
> * On Sat Apr 11, 2009 at 12:59:17PM -0400, Shane wrote:
>> Unless anyone has any objections I will go with David's suggestion of dropping
>> the  "AND duplicate <> 0" clause from the max episodes query in the scheduler.
>>
>> I will wait a few more days before committing.
>
> I think that's fine.  After looking this and the orginal commit over, I
> am wondering if the [15808] change would have been better to set
> recorded.preserve = 1 which would eliminate the recording from being
> included in the autoexpire maxepisodes count as well as this scheduler
> query.
>
> This would also have the side-effect/benefit of keeping the original
> around until the user did get a second copy of the recording and deleted
> the original manually rather than having the recording get bumped off
> because of the regular maxepisodes or autoexpire processes if it took
> a while to get a new copy of the desired recording.

Not 100% sure but setting preserve=1 looks like it would protect the recording
from being bumped off due to maxepisodes but still eligible for autoexpire?

I've attached a v3 patch to the ticket, v2 was bogus and I removed it.

v3 unconditionally sets preserve=1 in PlaybackBox::doAllowRerecord(),
which would make "Forget Old" in mythweb inconsistent with "Forget Previous"
in the frontend. :/   There are likely other ramifications I haven't
thought of too.

Now I'm thinking the special case of preserving an episode while trying to
record another copy when maxepisodes is set is separate from the problem I
set out to solve and should be dealt with in a separate patch.

Shane