[mythtv] [mythtv-commits] Ticket #6774: Perl Bindings do not Recognize H264
Michael T. Dean
mtdean at thirdcontact.com
Sun Aug 9 05:37:44 UTC 2009
On 08/08/2009 10:40 PM, MythTV wrote:
> #6774: Perl Bindings do not Recognize H264
> Comment(by disafan):
> I've submitted a patch above. I'm not fluent in perl, but the above
> modifications allow a fallback to the alternate DEMUXER for the height and
> width if the width = 0 and they modify the expression to allow VIDEO H264
> or VIDEO: MPEG2, thus eliminating the problems and allowing programs,
> including Nuvexport(which was my goal), to stop throwing exceptions.
Rather than fallback to the lavc demuxer, it makes more sense to just
use it in the first place. I know lavc works fine for my (OTA ATSC)
MPEG-2 and I would assume it would work fine for the MPEG-2 from ivtv
and the MPEG-4 from Plextors (if anyone's still using those). And,
since _nuv_info() is used for NUV, we shouldn't have to worry about it.
Personally, I (the guy who does /not/ make the decision) would rather
just replace the demuxer and wait to see if we get problem reports
rather than write code that has to spawn a 2nd mplayer process for every
H.264 program "just in case" there might be problems with
currently-working recordings if we change the first run. As it is,
load_file_info() /kills/ the system when run on all recordings, so
making it 2x as bad is not a good thing.
Ideally, though--since you probably don't have access to all the MPEG
recording types out there--you'd post a little test script that takes a
filename or chanid/starttime and outputs the fileinfo so others can
apply the patch that changes demuxer and then test with their recordings.
More information about the mythtv-dev