[mythtv] [mythtv-commits] Ticket #6865: Apply mirror effect to MythCenter watermarks like it is in MythCenter-wide

[Paul Harrison]

Robert McNamara wrote:
> On Mon, Aug 17, 2009 at 7:05 PM, MythTV<mythtv at cvs.mythtv.org> wrote:
>   
>> #6865: Apply mirror effect to MythCenter watermarks like it is in MythCenter-wide
>> ----------------------------------------------+-----------------------------
>>  Reporter:  Marc Alban <marcalban at gmail.com>  |       Owner:  ijr
>>     Type:  patch                             |      Status:  new
>>  Priority:  trivial                           |   Milestone:  0.22
>> Component:  Themes                            |     Version:  head
>>  Severity:  low                               |     Mlocked:  0
>> ----------------------------------------------+-----------------------------
>>  The mirror effect on the MythCenter-wide watermarks looks good.
>>
>>  This patch applies the same effect to the non-wide MythCenter theme.
>>     
>
> Hi Marc,
>
> I'm not opposed to the change (though I'm by no means the only one
> decide such things), but the problem with effects applied to
> watermarks (as I understand it) is that we take a performance hit in
> applying them versus just editing the static image and adding the
> reflection to that.  The prevailing wisdom as I understand it is that
> the reflect attribute should be used on dynamic images provided by the
> user (coverart, fanart, etc.), and that static images (like
> watermarks) should have it applied in an image manipulation program to
> save the user the performance hit.
>
> Let me know what you think about that.  Perhaps a compromise of
> changing the watermark images in GIMP and applying those instead?
>
> Robert
>   

Why should the default (4:3) theme be any different than the
default-wide one? The images are only draw with the reflection once when
they are first used and then saved in the image cache. The next time
that image is needed it is loaded from the cache not redrawn again at
least that is the way it's supposed to work if not then something is
broken.

My guess is the only reason the 4:3 theme wasn't changed is because
whoever committed the original was using the wide theme and either
forgot or couldn't be bothered to change the 4:3 one.

I would vote to make them look the same.

Paul H.