[mythtv] DVD navigation issues

[Jim Stichnoth]

With the recent fixes for smooth DVD playback and at the proper speed,
I started using it more.  I noticed a couple of issues so far.

First issue.  Normally, when you press Down (JUMPFFWD) or PgDown
(CHANNELDOWN), it skips to the next chapter.  However, if you're in
the last chapter of a title, it displays "Next Title" on the OSD but
does nothing.  This turns out to come from a strange conditional in
DVDRingBufferPriv::GoToNextProgram().  Removing this conditional seems
to fix the problem, but maybe someone more knowledgeable on libdvdnav
could comment.

--- libmythtv/DVDRingBuffer.cpp (revision 22949)
+++ libmythtv/DVDRingBuffer.cpp (working copy)
@@ -682,14 +682,14 @@
 void DVDRingBufferPriv::GoToNextProgram(void)
 {
     QMutexLocker locker(&m_seekLock);
-    if (!dvdnav_is_domain_vts(m_dvdnav))
+    //if (!dvdnav_is_domain_vts(m_dvdnav))
         dvdnav_next_pg_search(m_dvdnav);
 }

 void DVDRingBufferPriv::GoToPreviousProgram(void)
 {
     QMutexLocker locker(&m_seekLock);
-    if (!dvdnav_is_domain_vts(m_dvdnav))
+    //if (!dvdnav_is_domain_vts(m_dvdnav))
         dvdnav_prev_pg_search(m_dvdnav);
 }

Second issue.  Skipping past a still frame does not work.  "Skip Still
Frame" is displayed on the OSD, but otherwise nothing happens.  I
tried unsuccessfully to figure this out.  It seems like
DVDRingBufferPriv::safe_read() is doing something reasonable with
respect to m_stillFrameTimer, except that the "case
DVDNAV_STILL_FRAME" label is never entered.  It looks like still
frames are handled at a higher level, maybe something to do with the
decodeStillFrame field of AvFormatDecoder.  I haven't been able to
figure this out yet, but it sure would be nice to skip past copyright
notices, FBI warnings, etc.

Jim