[mythtv] [mythtv-commits] Ticket #7778: Up and down scrolling directions are reversed in MythGallery

Michael T. Dean mtdean at thirdcontact.com
Sun Dec 20 05:04:33 UTC 2009


On 12/19/2009 11:07 PM, MythTV wrote:
> #7778: Up and down scrolling directions are reversed in MythGallery
>
> Comment(by Clayton Smith <argilo@…>):
>
>  Replying to [comment:1 mdean]:
>  > The scrolling seems to work as designed (and as originally implemented
>  in [1735] ).  The bindings used are "SCROLLUP" (with help text, "Scroll
>  image up," and default binding of 2) and "SCROLLDOWN" (with help text,
>  "Scroll image down," and default binding of 8).  When you use the SCROLLUP
>  binding (2), the /image/ is moved up while the viewport remains fixed, so
>  you see a portion of the image lower than the portion you were seeing.
>  Similarly, when you use the SCROLLDOWN binding (8), the image is moved
>  down while the viewport remains fixed, so you see a portion of the image
>  higher than the portion you were seeing.
>
>  If that's the case, then why doesn't SCROLLLEFT move the image left and
>  SCROLLRight move the image right?  They both move the viewport, as one
>  would expect.
>   

Well, I didn't write the code, so I couldn't tell you.  All I can say 
for sure, though, is that this is how it's always worked.

Perhaps a patch to the key description, then?  As it is, it works like 
the keys on the numeric keypad on a keyboard indicate it should work, 
and changing which keys it uses is as simple as changing bindings in 
MythControls.  So, unless we really change things/simplify things/make 
it more consistent with the rest of MythTV, I would argue we shouldn't 
change it since it's always been this way.

>  > My preference, however, would be to completely get rid of the SCROLLUP,
>  SCROLLDOWN, SCROLLLEFT, and SCROLLRIGHT bindings used /only/ by
>  MythGallery and change the plugin to use the global UP, DOWN, LEFT, and
>  RIGHT bindings used everywhere else in Myth--where UP would scroll the
>  viewport up (so you see a higher portion of the picture) and DOWN would
>  scroll the viewport down (so you see a lower portion of the picture).
>  Using the global directional keybindings works well for *both* keyboards
>  and remotes (and would work fine for a remote without arrows if the user
>  overrides the global bindings for the directional keys in the Gallery
>  context to use numbers as now).  I have a patch in the works that would
>  allow users to add a new keybinding to a context using MythControls--
>  effectively allowing users to override bindings in lower contexts with the
>  GUI keybinding editor instead of direct DB editing.
>
>  UP/LEFT are already used to move to the previous image, and DOWN/RIGHT
>  move to the next image.  Are you proposing changing the behaviour so that
>  these keys behave differently during zooming, and not using the numeric
>  keypad any more for scrolling?

Ah, didn't realize that those were already used--though I think using 
the global PREVVIEW (Home) and NEXTVIEW (End) for previous and next 
image would be more consistent with the rest of Myth***.  If we did 
that, then UP/DOWN/LEFT/RIGHT could be used to move the zoomed-in image 
up/down/left/right, and we wouldn't need to use the number-key hack we 
currently have--though I don't know what would work well for ROTRIGHT 
(3), ROTLEFT (1), RECENTER (5), ZOOMOUT (7), ZOOMIN (9), and FULLSIZE 
(0), so maybe it's not worth changing these.

I really don't know or use MythGallery, so as I mentioned, I'll let 
someone else who has more of a stake in the resolution decide.

Mike


***And, while we're at it, we could change the HOME and END actions used 
by MythGallery (only in thumbnail view) and MythVideo to go to the 
first/last item to use the global PREVVIEW and NEXTVIEW.


More information about the mythtv-dev mailing list