[mythtv] Ticket #6666: Popups may not close if screen focus lost whilst popup is displayed

[Marc Tousignant]

> On 04/07/2009, Simon Kenyon <simon at koala.ie> wrote:
> > Nick Morrott wrote:
> >
> > > On 03/07/2009, Rob Smith <kormoc at gmail.com> wrote:
> > >
> > >
> > > >  If you wanted to debug the issue, firebug is a excellent
> javascript
> > > >  debugging tool for firefox, that would at least give an
> indication of
> > > >  where the problem is.
> > > >
> > >
> > > I've looked with Firebug and had a go at editing the source to see
> if
> > > I could get it to work, but no success. I can see with the HTML
> > > inspector within Firebug that the value of <div id="help_text"
> > > style="display: none;"> is being set to the correct text to display
> -
> > > the issue is that is just isn't being displayed. I've looked at
> > > http://svn.mythtv.org/trac/ticket/4755 (patch committed
> > 13 months ago)
> > > but am still at a loss as to why it isn't working.
> > >
> > >
> >
> >  check to make sure that your php is built with json support
> >  rebuilding it, fixed the problem for me
> 
> I have JSON support built in per 'php -i' and do not have a problem
> with popups:
> 
> /etc/php.d/json.ini,
> json
> json support => enabled
> json version => 1.2.1
> 
> Nick
> 
> --
> Nick Morrott
> 

Nick,

I checked with FF 2.0, the help messages work in trunk there too.
I just compared utils.js, which is where the code for the help_text is
coming from. There is a small difference between them but it would not be
the cause of this as its not in the help_text function. Not actually sure
why its there. But it was removed for trunk, so it is not needed.
*** utils.js.21-fixes   2008-02-22 16:52:46.000000000 -0500
--- utils.js.22-trunk   2008-02-22 17:15:51.000000000 -0500
***************
*** 91,108 ****
          form.submit();
      }

- // Add a css class to a specified element
-     function add_class(id, classname) {
-         console.log('FIXME: add_class');
-         $(id).addClassName(classname);
-     }
-
- // Remove a css class from a particular element
-     function remove_class(id, classname) {
-         console.log('FIXME: remove_class');
-         $(id).removeClassName(classname);
-     }
-
  // Check/uncheck a checkbox
      function toggle_checkbox(id, check) {
          var e = $(id);
--- 91,96 ----

I thin I just found the issue.

Run this against modules/_shared/tmpl/default/header.php
After root in fixes there is no ; and in trunk there is. Might just be a
typo or completely unnessessary.

*** header.php.21-fixes 2008-03-08 16:09:11.000000000 -0500
--- header.php.22-trunk 2009-01-20 01:42:03.000000000 -0500
***************
*** 55,66 ****

      <meta http-equiv="content-type" content="text/html; charset=utf-8">

!     <script type="text/javascript" src="<?php echo root
?>js/prototype.js"></script>
!     <script type="text/javascript" src="<?php echo root
?>js/prototip/prototip.js"></script>
      <link rel="stylesheet" type="text/css" href="<?php echo root;
?>js/prototip/prototip.css">

!     <script type="text/javascript" src="<?php echo root
?>js/utils.js"></script>
!     <script type="text/javascript" src="<?php echo root
?>js/AC_OETags.js"></script>

      <script type="text/javascript">
          <!--
--- 55,67 ----

      <meta http-equiv="content-type" content="text/html; charset=utf-8">

!     <script type="text/javascript" src="<?php echo root;
?>js/prototype.js"></script>
!     <script type="text/javascript" src="<?php echo root;
?>js/prototip/prototip.js"></script>
      <link rel="stylesheet" type="text/css" href="<?php echo root;
?>js/prototip/prototip.css">

!     <script type="text/javascript" src="<?php echo root;
?>js/utils.js"></script>
!     <script type="text/javascript" src="<?php echo root;
?>js/AC_OETags.js"></script>
!     <script type="text/javascript" src="<?php echo root;
?>js/table_sort.js"></script>

      <script type="text/javascript">
          <!--