[mythtv] Ticket #7010: ./cpsvndir causes errors with checkinstall for themes

Peter Stokes mythtv at dadeos.co.uk
Fri Sep 11 18:25:08 UTC 2009


On 10 Sep 2009, at 23:47, David Engel wrote:

> On Wed, Sep 09, 2009 at 06:53:07PM +0100, Peter Stokes wrote:
>> On 9 Sep 2009, at 03:10, David Engel wrote:
>> The problem appears to be that "if [ -d "$file" ];" returns true for
>> symbolic links that refer to directories. This results in the
>> cpsvndir script creating a directory for the symbolic link, which is
>> incorrect.
>
> That's taken care of now.

Thanks.

One last thing, hopefully!

I've noticed that you've removed the "&> /dev/null" I/O redirect from  
the "chown" statement. I am not sure under which circumstances errors  
can be generated from "chown" (e.g. if a file not belonging to the  
user executing the cpsvndir script is copied, and the ownership is  
preserved, then might the user not have permissions to change the  
ownership of the resultant file?). However, now that symbolic links  
are supported, errors whilst installing several themes (e.g. blootube- 
wide) where symbolic links are being copied before the files that they  
refer to are being displayed on the console. I think that the fix for  
this is to add the "-h" option to the "chown" statement to prevent it  
from dereferencing the symbolic link. This would also potentially  
change the ownership of the symbolic link, which is presumably  
desirable.

As for whether the I/O redirect is necessary, I'll leave that up to you.

Thanks

Peter




More information about the mythtv-dev mailing list