[mythtv] Start Now Patch #8328 (Was Re: Ticket #6813: Patch to manage upcoming, recordings from the "Watch Recordings" screen)

[Bill]

> On Thu, Apr 15, 2010 at 09:25:06PM -0500, Bill wrote:
> > Two questions:
> >
> > 1. What's your (developers') opinion on ticket #8328?
>
> I don't really think it's needed. It's already fairly easy, and much
> more flexible, to change the start early setting with or without an
> override. I don't know if I feel strongly enough about it, though, to
> veto it.
>
> David 

One thing that's lost in this patch (my bad for muddying it up) is that 
it also fixes a corner case usability problem:

If a recording is in progress but it's in the pre / post roll time, you 
can't stop the recording or extend it from the "Upcoming Recordings" 
screen. I think this applies to Category Over, also.

The current code uses "recstartts <= now" and "recendts > now" tests to 
determine if the recording is in progress, but these tests apparently 
fail in the above conditions.  This patch changes the test to be 
"recstatus == rsRecording".

As for the "Start Now" functionality, it really is just a shortcut for 
"Create an override if necessary and set the start early time to be 
right now". It probably should be tagged "Start Recording Now", but the 
intention is to allow one button push ("Start Now") instead of

  1. "Edit Options"
  2. "Add Override"
  3. "Record Show With Override Options"
  4. "Schedule Options"
  5. "Start Recording x Minutes Early"
  6. "Save"

In any case, I'm fine with the "Start Now" logic getting dropped from 
this, but it would be nice to address the "Stop / Extend" usability issue.

-Bill