[mythtv] [mythtv-commits] Ticket #8656: Display video format in INFO OSD

[Mark Kendall]

On 30 August 2010 08:09, Nigel Pearson <nigel at ind.tansu.com.au> wrote:
> So, we could;
>
> 1) go back to the 4 or 5 values that are returned by
> get_encoding_type(GetDecoder()->GetVideoCodecID()),
> by reverting my change to videocodec, and maybe add a
> second value for those who just want a text description:
>
> infoMap["videocodec"]     = GetDecoder()->GetEncodingType();
> infoMap["videocodecdesc"] = GetEncodingType();

I don't really want to start adding 2 entries that are doing the same thing.

> 2) the statetype mappings could be expanded to use the new
> larger set that are now (currently) iterated in videocodec:

and I definitely want to avoid this approach.

I was going to suggest extending/completing the existing codec types
and descriptions in get_encoding_type to include things such as
NUV_MPEG4, FLV1, VP8 etc. The current set of 6/7 codecs probably
already cover off 99% of all clips seens in Mythtv and a couple of
extras would probably bump that to 99.9%. That would gives us
acceptable coverage and sticks with the previously agreed approach of
using a state type for the flexibility it gives the theme and because
it moves the translatable strings into the theme.

So unless anyone objects, I'll revert r25889 and extend the existing
'enumerations' in get_encoding_type.

Regards

Mark