[mythtv] DVD playback Pause/Unpause problems

[John Harvey]

My original attempt turned out to be just as flawed but in a different way.
I have spent more time investigating and now understand the issue i was
seeing and have created ticket
http://svn.mythtv.org/trac/attachment/ticket/7890/
It has a patch attached and a reasonable description of why i believe this
fixes the issue.

> -----Original Message-----
> From: mythtv-dev-bounces at mythtv.org [mailto:mythtv-dev-
> bounces at mythtv.org] On Behalf Of John Harvey
> Sent: 11 December 2009 13:52
> To: Development of mythtv
> Subject: Re: [mythtv] DVD playback Pause/Unpause problems
> 
> Any ideas in which way it didnt work? So far i've just put the locks in
> and it seems better but i havent seen any side effects yet, though i
> suspect it is not right. So if i know what failures to look for that
> would help.
> 
> Thanks
> 
> john
> 
> --- On Fri, 11/12/09, stanley kamithi <skamithi at gmail.com> wrote:
> 
> > From: stanley kamithi <skamithi at gmail.com>
> > Subject: Re: [mythtv] DVD playback Pause/Unpause problems
> > To: "Development of mythtv" <mythtv-dev at mythtv.org>
> > Date: Friday, 11 December, 2009, 5:58
> > davin is right. go ahead and open a ticket.
> > To answer your question, no one got around to putting locks
> > around code you mentioned and got it to work right. So if
> > you got it working, go ahead and submit your patches.
> >
> >
> > On Wed, Dec 9, 2009 at 11:57 PM,
> > Davin McCall <davmac at davmac.org>
> > wrote:
> >
> > Hi Jon
> >
> >
> >
> > I recommend just creating a ticket in trac (if there
> > isn't one already) and attaching a patch to it. I've
> > found that asking questions regarding how stuff works or is
> > meant to work on this list doesn't necessarily get a
> > response from the developers (not trying to issue blame,
> > just stating fact), so it's best to forge on ahead and
> > assume that if you see something that looks wrong, it
> > probably is wrong. Also best to send the patch to this list
> > with a note about what it's for / what it does and
> > asking people to test it.
> >
> >
> >
> >
> > Davin
> >
> >
> >
> >
> >
> > On 09/12/09 19:10, John Harvey wrote:
> >
> >
> > I am running into a problem with dvd playback where i can
> > trigger
> >
> > NuppelVideoPlayer::UnpauseVideo to loop forever, printing
> > the message
> >
> > "Waited too long to unpause video".
> >
> >
> >
> > The problem is caused by OutputVideoLoop calling
> > PauseVideo(false) whilst a
> >
> > different thread is in the middle of doing an
> > UnpauseVideo(true).
> >
> >
> >
> > For some reason the calls to PauseVideo&  UnpauseVideo
> > in OutputVideoLoop
> >
> > are not surrounded by locks on internalPauseLock. Is there
> > a good reason for
> >
> > this?
> >
> > Locking that from the OutputVideoLoop definitely seems to
> > help but i wanted
> >
> > to try to understand why they aren't there before
> > submitting a patch.
> >
> >
> >
> > I am also suspicious that calling PauseVideo(false) could
> > break things for
> >
> > the next call to UnpauseVideo if the video hasn't
> > actually paused by the
> >
> > time we call UnpauseVIdeo, though i have no proof of that
> > yet. Is this
> >
> > unfounded or is it worth investigating as well?
> >
> >
> >
> > Thanks
> >
> >
> >
> > Jon
> >
> >
> >
> > _______________________________________________
> >
> > mythtv-dev mailing list
> >
> > mythtv-dev at mythtv.org
> >
> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> >
> >
> >
> >
> >
> >
> > _______________________________________________
> >
> > mythtv-dev mailing list
> >
> > mythtv-dev at mythtv.org
> >
> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> >
> >
> >
> >
> > -----Inline Attachment Follows-----
> >
> > _______________________________________________
> > mythtv-dev mailing list
> > mythtv-dev at mythtv.org
> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> >
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev