[mythtv] [mythtv-commits] mythtv commit: r23182 by nigel
nigel at ind.tansu.com.au
Thu Jan 21 06:29:39 UTC 2010
> Would you mind also committing the modification to check for the presence of "pkg-config"? This overcomes a distracting error that is otherwise generated by the configure script when executed on systems without "pkg-config" (i.e. OS X).
Sadly, it silences one warning, but causes another (this on Linux):
% $ diff .svn/text-base/configure.svn-base configure
< if $(pkg-config --atleast-version 4.4.0 QtWebKit) ; then
> if `which pkg-config` && $(pkg-config --atleast-version 4.4.0 QtWebKit) ; then
% sh -x configure
++ which pkg-config
Must specify package names on the command line
> I am also slightly concerned about your modification to the QtWebKit test. I do accept that your modified version will yield the desired results but I find it unfortunate that the configuration check employs incorrect usage of the QtWebKit include statement.
I was trying for the smallest possible change, but OK, I will revise it.
Nigel Pearson, nigel at ind.tansu.com.au|"Beware - I am a carrier|
Telstra Net. Eng., Sydney, Australia | of surrealism"|
Office: 9202 3900 Fax: 9212 6348 | D A |
Mobile: 0408 664435 Home: 9792 6998 | L I |
More information about the mythtv-dev