[mythtv] [mythtv-commits] Ticket #7315: mythtranscode doesnt die after lossless transcoding to cut out ads
stichnot at gmail.com
Fri Jan 29 23:45:47 UTC 2010
On Thu, Jan 28, 2010 at 12:36 PM, MythTV <mythtv at cvs.mythtv.org> wrote:
> #7315: mythtranscode doesnt die after lossless transcoding to cut out ads
> Comment(by mdean):
> I think the proper fix is to just remove all of the slow delete code in
> mythtranscode and either send a message to the backend to have it delete
> the file or implement a solution similar to #6376 .
> Ticket URL: <http://svn.mythtv.org/trac/ticket/7315#comment:21>
I agree that this is ultimately the best fix. The current use of
fork() should be avoided since the child process doesn't inherit any
of the other threads, leading to lots of potential problems, such as
waiting forever for a nonexistent thread to quit.
In the meantime, why don't we simply disable the fork() call? We
already spent several minutes transcoding the file, would it really
hurt to wait another minute per GB to slow-delete the file before
moving on to the next job in the queue?
More information about the mythtv-dev