[mythtv] [mythtv-commits] Ticket #7315: mythtranscode doesnt die after lossless transcoding to cut out ads

[Michael T. Dean]

On 01/29/2010 06:45 PM, Jim Stichnoth wrote:
> On Thu, Jan 28, 2010 at 12:36 PM, MythTV wrote:
>   
>> #7315: mythtranscode doesnt die after lossless transcoding to cut out ads
>>
>> Comment(by mdean):
>>
>>  I think the proper fix is to just remove all of the slow delete code in
>>  mythtranscode and either send a message to the backend to have it delete
>>  the file or implement a solution similar to #6376 .
>>
>> Ticket URL: <http://svn.mythtv.org/trac/ticket/7315#comment:21>
>>     
> I agree that this is ultimately the best fix.  The current use of
> fork() should be avoided since the child process doesn't inherit any
> of the other threads, leading to lots of potential problems, such as
> waiting forever for a nonexistent thread to quit.
>
> In the meantime, why don't we simply disable the fork() call?  We
> already spent several minutes transcoding the file, would it really
> hurt to wait another minute per GB to slow-delete the file before
> moving on to the next job in the queue?
>   

That works for me--I like it as an interim fix.  I started on the patch
for removing the slow delete code, but when I realized that I'd need
another approach for files not in storage groups (for --video files that
people transcode, rather than recording files), it dropped a couple
notches on my TODO list.  It doesn't look like it will take all that
long, but I don't know that I'll get it in before 0.23.

Mike