[mythtv] [mythtv-commits] Ticket #8669: Remove "Change channels immediately without select" setting

[Michael T. Dean]

  On 07/21/2010 11:56 AM, Ian Campbell wrote:
> On Tue, 2010-07-20 at 14:04 -0400, Michael T. Dean wrote:
>> On 07/19/2010 05:26 PM, MythTV wrote:
>>> #8669: Remove "Change channels immediately without select" setting
>>>
>>> Comment(by Ian Campbell):
>>>
>>>    The "Change channels immediately without select" setting is already
>>>    disabled in my configuration ( doubled checked the DB and
>>>    SmartChannelChange == 0). Did you mean for me to enable it? (From what you
>>>    say I don't think so).
>>>
>>>    Note that I see the issue with recorded rather than live TV (I haven't
>>>    tried live), does "change channel" have any meaning in that context?
>>>
>>>    I have heavily instrumented tv_play.cpp and I am definitely seeing the
>>>    queueInputTimerId timer firing pretty much immediately after I press any
>>>    numeric button and causing the queuedInput to be wiped. 10ms for this
>>>    timer can't be right, can it?
>> Ian, none of the people I've talked to have been able to reproduce the
>> issue you're seeing.
> Hmm, well thanks for trying!
>> The code your patch changes has existed since the mythtv-vid branch
>> merge prior to 0.22 release (in Dec, 2008).
> IIRC this started happening when I updated to 0.23 earlier this year. I
> wouldn't swear to it though.
>> If you're applying any patches, please test with an unmodified version
>> of MythTV and see if you get the same behavior.
> I'm running the Debian packages from debian-multimedia.org, it has a few
> patches relating to locations of configuration files etc but nothing
> which looks pertinent to this issue.
>
> I suppose I should have mentioned already that my MythTV system and
> hence my investigations were initially based on 0.23-fixes, sorry for
> not thinking to mention this sooner.

I'm actually using 0.23-fixes on my production setup, which works fine 
(and I use arbitrary seek all the time on it).  I've talked to people 
using both -fixes and trunk.

>   I did look through the trunk
> history (24509 through HEAD) and diff the two versions of tv_play.cpp
> and didn't see anything which looked like a possible fix so ported the
> patch forward.

Right.

>> If so, please try to
>> isolate which setting(s) is causing the issue so we can reproduce it and
>> fix it.
> Will do, I guess the set of potentially interesting settings is those
> added to the kv map in the TV:TV constructor (i.e. the thing passed to
> MythDB::getMythDB()->GetSettings)?
>
> FWIW my database contains the following for those particular settings:
...
> I'll try playing with them, particularly the ones which are not the
> defaults.

None of those look like they'd be related.  You had mentioned that you 
weren't seeing the input when you were using an old, 
not-updated-to-current OSD theme.  Have you tried with a known-working 
theme?  One of the ones distributed in mythtv (like MythCenter) or 
myththemes (like Arclight)?  When using a working theme, you see the 
input, right?  What happens, next?  Does the number disappear from the 
OSD (but the window stays up)?  Does it all look correct on screen but 
when you hit a key to seek nothing happens?

If the latter, your key bindings are likely broken.  What are the 
mappings you have for the RWNDSTICKY and FFWDSTICKY actions in the TV 
Playback context?  Do you have anything mapped to LEFT and RIGHT in the 
TV Playback context (if they don't show up in Utilities/Setup|Edit Keys 
under TV Playback, that's fine--it means you don't).  What do you have 
for LEFT and RIGHT in Global context?

Mike