[mythtv] [mythtv-commits] Ticket #7994: Clear the bookmark at the end of playback
Michael T. Dean
mtdean at thirdcontact.com
Sun May 30 18:42:23 UTC 2010
On 05/30/2010 01:30 PM, MythTV wrote:
> #7994: Clear the bookmark at the end of playback
> Comment(by Jim Stichnoth):
> Updated to clear_bookmark_at_end_5.patch to fix a minor problem. I have
> some .mkv files under MythVideo for which IsNearEnd() finds that
> framesRead> totalFrames, which causes the wrong result to be returned.
Jim, since the IsNearEnd() change is completely unrelated to the focus
of the ticket (though, probably important to the patch), can you please
separate it out and create a separate ticket for review rather than try
and sneak it in as a line item. :) Then, just mention that the patch
on #7994 is dependent on the functionality in the patch on the new
ticket. Doing so will help to better document the changes.
Specifically, the IsNearEnd() change is important to review in light of
all the other tickets/discussions we've had about IsNearEnd():
http://svn.mythtv.org/trac/ticket/6974 , most importantly, and #6148,
#6448, as well as discussions on list.
Or, if you like, feel free to fix it properly:
More information about the mythtv-dev