[mythtv] [mythtv-commits] mythtv commit: r25892 by robertm

[Jarod Wilson]

On Wed, Sep 1, 2010 at 9:21 PM, buzz <davidbuzz at gmail.com> wrote:
> I recommend partially reverting or modifying this commit for the following
> reasons:
>
> * the original URL/s  are the primary and definitive location of the files ,
> so should be kept in the code and still available.   I'd suggest at the very
> least putting them in a comment or something.
>
> * When the specific version of a dependency that we use is removed from it's
> URL, it's because it's been replaced with a newer/better

Well, don't forget potentially "untesteder/brokener".

> version, so if the
> script continues to use to use an older "cached" version it makes it harder
> to correct the script ( smaller patches are easier).
>
> * It is harder ( impossible) to push any faults found with the dependancies
> back upstream to the author/s if we are using an old version.
>
> My suggested solution is this:
>
> * always check the original URL, using a http HEAD request, and if it's not
> available any more at that URL, throw a meaningful message describing the
> fact that you should see if a newer version is available.  ( see
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html section 9.4 )
>
> * after doing the above, if the file is still available AND it's at the
> google code repository, download it from the google repo ( since it's
> aparently faster).

I do sorta like the idea of making sure upstream hasn't pulled to code
for some reason, and/or checking to see if there's a newer version.
Could also maybe go with a build script switch. By default, use the
"known good" bits from the cache, but allow a "get the latest from
respective upstreams" flag to be provided. As the more adventurous
test out those bits, they get promoted to the cache as they prove
themselves stable and functional too. Don't want to put too much
burden on our already limited resources to have to support umpteen
different possible software combinations on a platform the bulk of the
development crew doesn't regularly build or run on. :)

-- 
Jarod Wilson
jarod at wilsonet.com