[mythtv] Ticket #9525: [PATCH] Mythbrowser does not use proxy set in http_proxy environment variable

[E. Westbrook]

On Mon, May 9, 2011 at 08:06, Michael T. Dean <mtdean at thirdcontact.com>wrote:

> FWIW, my (non-proxy-using) understanding is that the generally-accepted
> de facto "standard" approach for configuring proxy support in *nix is
> the use of the http_proxy and https_proxy environment variables.


Pretty much true.  However, because it is a "de-facto" Many *nix apps (e.g.
wget) seem to do both, that is, to use the environment variable if found,
but also provide a setting for it in the application's own configuration
file.


> So,
> using this--rather than a DB setting that the user has to find--would
> make our application work the same way as a lot of other *nix software.
>

Most that I've found, at least the better ones, do both.


> Chances are, users who do have proxies, already have the environment
> variable configured for some other software, anyway.
>

True enough, and reason enough that honoring the environment variable would
be prudent, regardless of anything else.  So let's do that.

Then, if it's not too much indigestion for those that dislike "settings
creep", by all means we can add our own GUI-less settings value to the
settings table.  If someone wants to honor an upstream library's setting on
top of that, that should be okay.  Personally, it's no big deal to me if all
settings alternatives aren't agreeable, but neglecting the environment
variable, at the least, in my view is a mistake.


> And if anyone wants to submit
> patches that determine proxy settings using GNOME/KDE/xdg configuration,
> that would work, too (though I'd argue that it's more useful to submit
> those patches to Qt on the bug report I referenced, above).
>

IMHO, such patches should definitely be applied against Qt and not MythTV
directly.

As for the environment variable... we have a working patch in this bug.

Does anyone NOT agree that the environment variable should be honored
regardless of anything else?  Does the patch need any rework in order to be
applied?

Thanks,
Eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.mythtv.org/pipermail/mythtv-dev/attachments/20110509/dd58bb5e/attachment.html