[mythtv] Ticket #6948: LiveTV browse mode starts on wrong channel

John reidjr at lineone.net
Tue May 24 19:18:01 UTC 2011


On 24/05/11 20:09, John wrote:
> On 24/05/11 18:32, Daniel Kristjansson wrote:
>    
>> On Mon, 2011-05-23 at 22:36 +0100, Simon Kenyon wrote:
>>
>>      
>>> On 05/18/11 00:51, MythTV wrote:
>>>
>>>        
>>>> #6948: LiveTV browse mode starts on wrong channel
>>>>
>>>>          
>>> there are a whole clatter of different bug reports associated with this:
>>> #6208, #6948, #8211, #9025 (not at all sure about that one), #9137
>>>
>>>        
>> Heh, I'd be greatful if someone checked if those were all fixed as well.
>>
>>
>>      
>>> one that i raised #9161 is not fixed by this change
>>>
>>> but #9540 has a nice simple fix
>>> it is just one line
>>> could it be applied?
>>>
>>> --- a/mythtv/libs/libmythtv/tvbrowsehelper.cpp
>>> +++ b/mythtv/libs/libmythtv/tvbrowsehelper.cpp
>>> @@ -80,6 +80,8 @@ bool TVBrowseHelper::BrowseStart(PlayerContext *ctx,
>>> bool skip_browse)
>>>                          ctx->playingInfo->GetScheduledStartTime(ISODate));
>>>            ctx->UnlockPlayingInfo(__FILE__, __LINE__);
>>>
>>> +        m_chanid = ctx->playingInfo->GetChanID();
>>> +
>>>            if (!skip_browse)
>>>            {
>>>                locker.unlock();
>>>
>>>        
>> No, this accesses the playing info outside the lock and it does nothing
>> anyway since that line of code exists inside the lock four lines
>> earlier..
>>
>> -- Daniel
>>
>> _______________________________________________
>> mythtv-dev mailing list
>> mythtv-dev at mythtv.org
>> http://www.mythtv.org/mailman/listinfo/mythtv-dev
>>
>>
>>      
> Daniel,
>
> That was a simple hack from me, but it DOES do somthing, it fixes the
> problem. I deffer to you for where m_chanid should be set in the code,
> but as described in the ticket, without it m_chanid = 0 on entry to
> browsemode, whatever channel you are on. I patch each update of fixes
> with this one liner, when I forget, it doesnt work :-)
>
>    
Oops,

Looked back over the thread and I see I took your comment out of 
context: Can I change my comment to
" can we have the fix in fixes, now you have implemented it properly in 
Master " ;-)

John


More information about the mythtv-dev mailing list