[mythtv] [mythtv-commits] Ticket #10045: Prevent looping in button list when less than three buttons

Xavier Hervy xavier.hervy at gmail.com
Mon Sep 19 18:17:53 UTC 2011


On 19/09/11 17:03, Robert McNamara wrote:
> On Mon, Sep 19, 2011 at 7:12 AM, Dan Wilga
> <mythtv-dev2 at dwilga-linux1.amherst.edu>  wrote:
>
>> Without this patch, pressing Down always toggles the states of both
>> buttons, and it's not obvious which has focus.
> With the patch, the theme author's control over the wrap style is
> broken, and only when there are two items-- so the user becomes
> accustomed to the buttonlist behaving a certain way, and then it
> conditionally doesn't work that way.  I don't like the conditional
> hardcoding of wrap behavior like this.  If you really want it to
> behave this way, just set the buttonlist to a wrapstyle of none.  Then
> you'll get what you want, and it's consistent.
>
> Robert
What I was trying to explain is that there is not point to loop when the 
list consist of only two buttons.
This is not the same a changing the wrapStyle to none, as I do want to 
be able too loop if there is more than 3 button.
Talking about consistency if any list of two items does not loop when 
the wrap style > none sound consistent to me, depends where you look for 
consistency ;)

Anyway, another way to reach this goal could be to create a new wrapping 
style ? (autowrap or something)

Regards,
Xavier



More information about the mythtv-dev mailing list