[mythtv] [mythtv-commits] mythtv/master commit: 9b7eae2fd by Jonatan Lindblad (natanojl)

Paul Harrison mythtv at sky.com
Sat Feb 18 17:49:57 UTC 2012


On 18/02/12 14:19, Jonatan Lindblad wrote:
> 2012-02-18 14:52, Paul Harrison skrev:
>> On 12/02/12 23:50, MythTV wrote:
>>>        Author:  Jonatan Lindblad<jlindblad at mythtv.org>
>>>   Change Date:  2012-02-12T15:15:15-08:00
>>>     Push Date:  2012/02/12 15:49:53 -0800
>>>    Repository:  mythtv
>>>        Branch:  master
>>> New Revision:  9b7eae2fda2e15d20bc846dcef756c05f09d6ac0
>>>     Changeset:  https://github.com/MythTV/mythtv/commit/9b7eae2fd
>>>
>>> Log:
>>>
>>> MythUI: Add a scroll bar widget.
>>>
>>> Add a scroll bar widget and use it in MythUIButtonList.
>>>
>> Hi Jonatan,
>>
>> This seems to be causing images in the buttonlists to sometimes not be
>> updated properly.
>>
>> The place I noticed it is in MythMusic if you replace the tracks in the
>> current playlist (eq if you select one of the quick playlist options)
>> the coverart images don't update until you scroll in the list.
>>
>> Paul H.
> Hi Paul,
>
> I have reproduced the problem and will try to fix it.
>
> --
> Jonatan

OK thanks for looking at it. I suspect it's the changes to the
m_needsUpdate flag which is always set to false in DrawSelf() now were
before it wasn't if m_clearing was true because SetPositionArrowStates()
bailed out early before it set m_needsUpdate to false. That would
explain why it only happens after the buttonlist is reset.

I'm also seeing strange behaviour in MythBrowser when scrolling using
the mouse. I haven't reverted to see if it definitely is your other
scrollbar widget commit but I can't think of anything else that may have
broken it.

Paul H. 


More information about the mythtv-dev mailing list