[mythtv] Looking to commit code...

[George Nassas]

On 2012-03-05, at 3:33 PM, David Blain wrote:

> NOTE: Had to change the way QVariantMap is serialized to XML.  Key is no
> longer an attribute.  Now it's an element.  I would prefer this going in now
> so we can keep the interface to the Services API fairly stable  (would hate
> to have to change the schema post 0.25).  Also, not many people should be
> using this interface yet.


Kind of in the same vein are bitmask properties like recording video and audio properties. Right now a raw integer is written which is a pain to interpret. You'd expect the json to look like this:

VideoProps:
  {
    VID_DAMAGED : false,
    VID_1080 : true,
    ...
  }

Same deal for enums: a recording's status is written as an integer where you'd expect to see "rsRecorded" etc.

Is the bitmask thing intentional? Slip through the cracks?

If you give a hint for how to implement it I could whip up a patch assuming that such changes are welcome at this late stage.

- George
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.mythtv.org/pipermail/mythtv-dev/attachments/20120306/7a2463c2/attachment.html