[mythtv] [mythtv-commits] Ticket #6974: last few seconds of video are not played
stichnot at gmail.com
Mon Jan 7 02:51:02 UTC 2013
On Sat, Jan 5, 2013 at 8:04 PM, Mark Spieth <mark at digivation.com.au> wrote:
> However I dont think you need it with your implementation because the player
> doesnt stop until framesPlayed (from videooutput->GetFramesPlayed())
> indicates completion.
> This should be consistent with ValidVideoFrames being 0 and thus the check
> should not be necessary.
> If this is not true, then it should be (IMO). It should be a pointless test.
Actually, for all of my HD-PVR recordings, your patch has real value
on top of the IsNearEnd change. Without the patch, playback stops
about 30 frames early (using the software decoder with a buffer size
of 32 frames). For my ATSC recordings, the benefit is less clear,
probably because of the audio/video buffering mismatch.
More information about the mythtv-dev