[mythtv] [mythtv-commits] Ticket #12157: List all recordings with this title (display group)

[Michael T. Dean]

On 05/30/2014 08:52 AM, Jean-Yves Avenard wrote:
> On 30 May 2014 21:25, Angela<angela.schmid at wolke7.net>  wrote:
>>> This is a long awaited feature (for me at least).
>>> Can the current LEFT/RIGHT Arrow be used by default, as currently you
>> press
>>> right from the All Programs to the recordings, then right again on the
>>> recording to get all recordings of that title.  (and then left to
>>> back out).   Don't see why it needs a new key binding.
>> I was thinking about the same, using LEFT/RIGHT, to scroll through the
>> display group.
>> Another thought was to have LEFT as before to move to the recordinglist,
>> from where you use UP/DOWN and having RIGHT to select the display group of
>> this title, instead of using a new key binding (+).
>> I am quicker with LEFT/RIGHT, than I am with PREV/NEXTVIEW, as a need to go
>> up on the remote and they are between other keys, so hitting them is a
>> little bit difficult.
>>
>> There are several places where we use four buttons:
>> Playback: (depending how configured) Commercial Skip, FFWD or using 2
>> different time intervals.
>> Program Guide: Day left/right, screen portion left/right
>> NetVision, I made a patch to skip 1 Pages and 10 Pages
>>
> while in the recordings list screen, using the MythBuntu theme
> You start by being on the list of titles. You press Right and you're
> on the content list (default being All Programs)
>
> To me, pressing Right would be really nice if it showed all the
> programs with the same title (what this patch does)
> however, re-binding LEFT/RIGHT isn't really a possibility as how they
> behave depends on the theme. Horizontal theme (like Terra) have an
> action for right already.

Correct.  Having a specific action would allow themers to choose to 
submit that action using the "theme can override any action to perform 
any other action without warning to the user" feature (i.e. the "In my 
theme, hitting RIGHT on a currently selected recording will issue DELETE 
because that's intuitive to me. What you accidentally deleted a very 
important recording? Oops!" feature), specifically the <triggerevent>.

Most themes that have done so have made RIGHT issue MENU, though themes 
could be modified to use SELECTDISPLAYGROUP.  However, that would mean 
that RIGHT issues SELECTDISPLAYGROUP regardless of whether we're in that 
display group or not.  It would make sense to be able to do something 
different if, for example, I'm in the 24: Live Another Day group with a 
24: Live Another Day episode selected and I hit SELECTDISPLAYGROUP, 
however the only way to do so is to override the binding in code.

The problem with overriding bindings is that everyone gets the behavior 
that's coded in.  So, if we make it so that SELECTDISPLAYGROUP when 
already in the display group issues PLAYBACK, we'll get complaints that 
it should issue MENU.  If we make it issue MENU, we'll get complaints 
that "RIGHT already issues MENU (in my theme of choice), so it's a waste 
to have another key do that."

This is why we need to eventually unroll all the action overrides, but 
doing so requires a lot of new code to allow proper fallback/"inheritance".

> Finding a proper and intuitive key binding, may be too much to decide.
>
> So I suggest having a menu entry instead, Between Add To Playlist and
> Mark As Watched
>
> There we would have, "Find other show like this one"

Agreed.  This functionality is useful enough to add to the menu.  That 
way it's always available, even if the user doesn't have enough 
available remote buttons.  That said, we should still have the specific 
action for it for those users who do have the buttons available.  (I 
think this is what you meant, JYA--"instead" meaning instead of trying 
to get the perfect key binding, not in place of the key binding.)

Mike