<br>daniel,<br><br>i will revert the patch, pending your review. <br><br><br><div class="gmail_quote">On Mon, Feb 1, 2010 at 8:07 PM, Daniel Kristjansson <span dir="ltr"><<a href="mailto:danielk@cuymedia.net">danielk@cuymedia.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On Mon, 2010-02-01 at 17:30 +0000, <a href="mailto:mythtv@cvs.mythtv.org">mythtv@cvs.mythtv.org</a> wrote:<br>
> Author: skamithi<br>
> Date: 2010-02-01 17:30:32 +0000 (Mon, 01 Feb 2010)<br>
> New Revision: 23428<br>
> Changeset: <a href="http://svn.mythtv.org/trac/changeset/23428" target="_blank">http://svn.mythtv.org/trac/changeset/23428</a><br>
><br>
> Modified:<br>
><br>
> trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp<br>
> trunk/mythtv/libs/libmythtv/vsync.cpp<br>
> trunk/mythtv/libs/libmythtv/vsync.h<br>
><br>
> Log:<br>
><br>
> Refs #7067 patch from davin mccall. resolves av sync issues when watching certain dvds. simplified the interface between vsync and NuppelVideoPlayer. The videosync/vsync object now has no knowledge of the video framerate and instead gets the frame rate for each frame as part of the WaitForFrame call. tested it on various recorded shows, avis and dvds. no problem yet. applying to trunk to expand test audience.<br>
<br>
</div>Stanley, I can't speak to how good or bad this solution is as I haven't<br>
reviewed it, but I don't think it is a good idea to apply an A/V sync<br>
or V-Sync patch this late in the release cycle.<br>
<br>
-- Daniel<br>
<br>
_______________________________________________<br>
mythtv-dev mailing list<br>
<a href="mailto:mythtv-dev@mythtv.org">mythtv-dev@mythtv.org</a><br>
<a href="http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev" target="_blank">http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev</a><br>
</blockquote></div><br>