[mythtv-users] Bug(s) found and fixed, and larger problems found as well

[Declan Shanaghy]

Fred,
Im having the same problem as u, but i cant fully
understand where u made these changes, can you send me
your
modified version of filldata.cpp, please.

Thanks.
Dek    (declanshanaghy at yahoo.com)



> --- Funky Fred <funkyfredmale at hotmail.com> wrote:
> > I found out why my mythfilldatabase was seg faulting.
> > In parseProgram in filldata.cpp I found two errors:
> > 
> > (1)
> > before calling split() to remove the EST off the
> > date/time, no check was 
> > made to see if the string was null, and the function
> > split = split(" ", 
> > text) seg faulted. (this is really Qt people's fault,
> > split should not seg 
> > fault, it should report some error). So I use the
> > function text.mid(0, 14), 
> > since fromXMLTVDate basically assumes a string of
> length
> > 14 anyway. This 
> > took care of it so far for me. Also if the string was
> > empty, I just went 
> > ahead and made the end time equal to the start time, to
> > prevent too many 
> > repeats because of this. I don't really advise this
> > though, it's the kind of 
> > hack that will cause issues in the long run.
> > 
> > and in the fromXMLTVDate method in the same class:
> > (2)
> > in fromXMLTVDate, a check was made to see if text was
> > null   using the 
> > following method-  if( text == QString::null )
> > Unfortunately for reasons unknown to me, this statement
> > does not work at all 
> > (it should, according to Qt's documentation). I also
> > tried text.ascii() != 
> > "" and
> > text.ascii() != '\0'. Neither of these work, even
> though
> > when I cout << 
> > text.ascii() << endl; it simply printed out  nothing
> > (except the newline 
> > from endl). This make's no sense to me at all, but it
> > appears 
> > text.isEmpty(), and text.length() do their job as
> > specified by Qt (I 
> > think!), and are suitable in the place of this check as
> > !text.isEmpty() or 
> > text.length != 0. This prevents a seg fault as the text
> > == QString::null was 
> > intended to do.
> > 
> > And of course the real source of these problems are
> > two-fold, and not the 
> > fault of anyone at mythtv.
> > (1) XMLTV does not get all the program info in the
> proper
> > format. 
> > Unfortunately, this is problem most likely not XMLTV's,
> > but the providers. 
> > The channels with bad entries were mostly public
> > stations, and some other 
> > less well-funded stations, that probably don't make the
> > spaces in their 
> > listings a priority (I am just shooting in the dark
> here,
> > though, but no 
> > need to shoot me down for it).
> > 
> > (2) QT's functions do NOT do what QT said they would
> do.
> > Don't know what to 
> > do about this (don't use QT???).
> > 
> > Hope this info helps a little. Feels nice to think you
> > contributed for once.
> > 
> > Stuart Smith
> > 
> > PS. sorry if this email has any grammar/spelling errors
> > in it. Proofreading 
> > sucks on hotmail.
> > 
> >
>
_________________________________________________________________
> > Add photos to your e-mail with MSN 8. Get 2 months
> FREE*.
> >  
> > http://join.msn.com/?page=features/featuredemail
> > 
> > _______________________________________________
> > mythtv-users mailing list
> > mythtv-users at snowman.net
> > http://www.snowman.net/mailman/listinfo/mythtv-users
>