[mythtv-users] Left over .png files

[James Orr]

On Fri, 2006-03-03 at 14:00 -0500, James Orr wrote:
> On Fri, 2006-03-03 at 13:28 -0500, Michael T. Dean wrote:
> > >  but I don't mind them being there as long as they go away
> > > with the actual recording.
> > 
> > They always have for me.  Are you sure you're never deleting files 
> > outside of mythfrontend/MythWeb?  Are you getting any messages in your
> > backend log?
> 
> I only delete files from the frontend.  I don't see anything in the
> backend log indicating a problem deleting the files.  It does not leave
> every thumbnail behind, only some, and permissions are the same on all
> of them, so it's not an issue there.
> 
> I have watched and deleted a show since my earlier messages and the
> thumbnail did not remain.  Looking at the thumbnails that have not been
> removed it looks like these are shows that I watched either while the
> recording was in progress or shortly after it finished, and was then
> deleted while the commercial flagging process had either not finished or
> perhaps even not yet started.

OK, I also noticed that the timestamp on the PNG file is the same time
the commercial flagging finishes, and I confirmed this in the source
code.

If you look at jobqueue.cpp you can see the preview being generated at
line 2091 (0.19 code, not SVN) AFTER commercial flagging has finished.

So, I guess when I delete a file that's being flagged it appears to the
backend the same as when flagging finished normally and it creates the
image.  

I'm guessing the most obvious solution is to move the thumbnail
generation so that it happens BEFORE commercial flagging and not AFTER.
This also seems to make more sense to me, as sometimes it can take
several hours to flag a program if there have been a lot of other
programs recorded at or around the same time.

Unfortunately I don't really have a suitable system setup to test any
changes I might make.

-- 
James Orr <james at orrwhat.net>