[mythtv-users] MythGame: indepth scanning not working

[Markus Lehtonen]

On 2/23/07, Markus Lehtonen <knaeaepae at gmail.com> wrote:
> On 2/22/07, Greg Estabrooks <greg at phaze.org> wrote:
> >  Can you show me the complete output of the row from the gamemetadata and the matching romdb entry ?
>
> Here is an example row from sql when I use a zipped rom:
> system  romname gamename        genre   year    publisher       favorite        rompath
> gametype        diskcount       country crc_value       display version
> NES     Arkanoid (U).zip        Arkanoid
> (U)     UnknownNES      19xx    Unknown NULL    /myth/emulators/nes/roms        NES     1       Unknown 32fb0583        1       0
>
>
> When I use unzipped rom the row looks like this:
> system  romname gamename        genre   year    publisher       favorite        rompath gametype        diskcount       country crc_value       display version
> NES     Arkanoid (U).nes        Arkanoid                1987    Unknown NULL    /myth/emulators/nes/roms        NES     1       U.S.A.  32fb0583        1       2005110101
>
>
> There are two rows in romdb matching the CRC:
> crc     name    description     category        year    manufacturer    country publisher       platform        filesize        flags   version binfile
> 32fb0583        Arkanoid        Arkanoid (U)            1987            U.S.A.  Unknown NES     49152   1PL 2PA
> ARC PUZ 2005110101
> 32fb0583        Arkanoid        Arkanoid (U)
> [o1]            1987            U.S.A.  Unknown NES     49280   1PL 2PA ARC PUZ 2005110101

Hi,

I took a closer look to the problem and managed to solve it. The
problem was that the romdb search algorithm used both the crc and the
file name - both must match - to find the correct entry. However, the
NES entries in the romdb have no file names (the 'binfile' fields in
the table are empty). Thus, mythgame did not find any matching
entries. I changed the code so that the rom filenames are omitted and
the problem was solved.

Is there any reason to use the bin filename in the search (in addition
to the crc value)? Isn't the CRC value unambiguous?

I attached the patch that corrected my problem.

Best regards,
Markus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythgame.diff
Type: application/octet-stream
Size: 1653 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-users/attachments/20070518/ceeb3819/attachment.obj