[mythtv-users] Feature: Configurable LIRC client name [PATCH]

Paul Harrison mythtv at sky.com
Mon Feb 15 18:50:12 UTC 2010


David Kubicek wrote:
> Hello,
>
> I'm sending a small patch that enables changing MythTV's LIRC client
> ("program") name. This is quite useful when you have mythfrontend and
> mythtv-setup or several mythfrontends open at the same time. All these
> apps use "mythtv" client name by default, but by making this client
> name configurable, I can use the existing command-line overrides to
> allow different instances use a different name, hence different LIRC
> modes/mappings.
>
> When sharing "mythtv", I could not operate just one application at a
> time and I couldn't implement LIRC modes. I pressed UP, both
> application responded - it was a dangerous mess.
>
> Basically, the patch is a fix of status quo, plus adding awareness of
> a new setting called "LircClientName". Well, just see the patch, it's
> quite small.
>
> The fix means we're not ignoring "our_program" argument of LIRC class
> constructor any more. Apparently, devs already thought this should be
> a parameter, but then decided to ignore it and hard-code "mythtv" in
> LIRC::Init() anyway. I just made a change to actually use the value
> passed to the constructor (from mythmainwindow.cpp). The second change
> is in the caller (MythMainWindow::StartLIRC) - instead of passing
> fixed "mythtv", I use the new option "LircClientName" if available. If
> not (as DB setting or CLI override), I still use "mythtv" as default.
>
> This change is completely backwards compatible, transparent, safe and
> provides a useful new feature. Many LIRC aware applications allow for
> program name change for various reasons. I hope you'll consider it,
> thank you.

You'd be better opening a ticket and adding your patch there so it
doesn't  fall though the cracks. Most of the devs don't bother to read
anything in the users list because of the high signal to noise ratio. 
danielk is probably  the best dev to assign the ticket to since he has
worked on the lirc code recently. Not sure that running more than one
myth app is a supported configuration but I'll let Daniel decide on that
one.

Paul H.


More information about the mythtv-users mailing list