[mythtv-users] [RFC] HD PVR kernel driver and mythtv patches

Alan Young ayoung at teleport.com
Tue Jul 27 08:50:12 UTC 2010


Janne Grunau wrote:
> On Sun, Jul 25, 2010 at 05:45:41PM -0700, Alan Young wrote:
>   
>> I've been working with the HD PVR driver and mythtv for a couple of 
>> months now to try to figure out why it does not work well.  I've built a 
>> set of patches for the hdpvr kernel driver and mythtv that seem to 
>> address the many of the issues I've seen.  I will say up front that 
>> these changes make mythtv work much better for me.   I'm sending these 
>> changes out for comments (and if you are brave for your testing).  :-)  
>> The changes are not a cure all.  And I know the mythtv patch needs 
>> better than what I've done to it.  I still have a couple of other issues 
>> that need to be worked out (documented below).
>>     
>
> Thanks for your work on the neglected driver.
>
> I've only looked at the kernel patches and queued them at
> http://git.jannau.net/git/linux/log/?h=hd_pvr/20100726_ay
>
> I've changed several patches and fixed style issues, I've torn some
> apart combined some to have only related changes in a single commit.
>
> All commits with my sign-ofs are ok, please send your sign-of too after
> verifying that the commit messages are ok.
>
> "V4L/DVB: hdpvr: add error checks and debug messages to the URB callback"
> is in principle ok to, but I've found a buffer handling problem during
> review. My patch doesn't fix it.
>
> I would like to avoid changing the audio input and codec defaults. using
> the default_audio_input module option doesn't help?
>
> Janne
>   
You're welcome.

I'm going to be away from a PC until this weekend.  I'll pull the git 
tree when I get back and retest and send my sign offs.    I admit I 
didn't run them through checkpatch.pl as I didn't think they'd get 
queued up that quickly.   Thanks for cleaning them up.

I'm curious, what is the buffer problem that you are seeing?

Yeah, I'd like to avoid changing that default too.  Using the module 
parameters does not help.  The default change fixes for me a issue that 
several people are seeing with mythtv.  For some reason, something goes 
bad at the start of some recordings and the driver? the HD PVR? or 
mythtv?  thinks it is recording from a different input or codec.  The 
video is good, but it ends up having no sound.  In the mythtv logs, the 
detected audio codec shows audio-aac instead of audio-ac3 when using the 
SPDIF input.   There's a couple of threads about this problem on the 
list.  The most recent is here  
http://mythtv.org/pipermail/mythtv-users/2010-July/293482.html .  The 
originator is seeing it with the most recent firmware.   I've seen it 
with older firmware dated May 2009.

Alan



More information about the mythtv-users mailing list