[mythtv-users] MythArchive in 0.24: Sorting broken in 'Select Recordings'

John Drescher drescherjm at gmail.com
Wed Apr 6 14:53:44 UTC 2011


On Wed, Apr 6, 2011 at 10:38 AM, Paul Harrison <mythtv at sky.com> wrote:
> On 06/04/11 15:12, John Pilkington wrote:
>> On 06/04/11 14:29, John Drescher wrote:
>>
>>> I am pretty sure I know how to fix the ordering now however I have to
>>> get to the day job.. I will work on this sometime this week.
>>>
>>> John
>> Good to hear it.  My impression is that it's a change in the
>> initialisation of the 'iterator/s', but I haven't found out where that
>> happens.
>>
>> Good luck!
>>
>> John P
>
> No the problem was the list of recordings sent by
> RemoteGetRecordedList() was changed to be always unsorted when
> previously it was always sorted by time either ascending or descending
> depending on the passed parameter. This is something outside of
> MythArchive's control. I believe this should now be fixed by sphery in
> https://github.com/MythTV/mythtv/commit/e965e4bab1d37fd9fa94a5.
>
> The call to RemoteGetRecordedList() in
> RecordingSelector::getRecordingList() is passing true when it should be
> 1 but the result should be the same.

I was trying to figure out whether it was the myth coding standard
(not being a developer) to handle the sort in RemoteGetRecordedList or
just sort what it returns. Either way the change was going to be less
than 20 lines with the hardest part being figuring out what was the
standard..

John


More information about the mythtv-users mailing list