[mythtv-users] Bookmark cleared at end of playback?

[Jim Stichnoth]

On Thu, Dec 19, 2013 at 2:48 PM, faginbagin <mythtv at hbuus.com> wrote:

> On 12/18/2013 6:21 PM, Jim Stichnoth wrote:
> > On Wed, Dec 18, 2013 at 1:25 PM, faginbagin <mythtv at hbuus.com <mailto:
> mythtv at hbuus.com>> wrote:
> >
> >     On 12/17/2013 9:43 AM, Jim Stichnoth wrote:
> >      > On Mon, Dec 16, 2013 at 9:06 PM, faginbagin <mythtv at hbuus.com<mailto:
> mythtv at hbuus.com> <mailto:mythtv at hbuus.com <mailto:mythtv at hbuus.com>>>
> wrote:
> >      >
> >      >     I'm getting ready to upgrade from 0.23 to 0.27 and in my
> testing I ran across an unexpected change in behavior. If I have a bookmark
> set or set a bookmark and then let playback continue to the end of the
> recording, the bookmark is cleared. This is a change from the way it was
> working in 0.23, where bookmarks were never cleared.
> >      >
> >      >     My bookmark related settings for both 0.23 and 0.27 are
> identical and are as follows:
> >      >     General Playback (1/8)
> >      >              Clear bookmark on playback Unchecked
> >      >              Alternate clear and save bookmark Unchecked
> >      >     General Playback (2/8)
> >      >              Action on playback exit: Save position and exit
> >      >              Prompt at end of recording Unchecked
> >      >
> >      >     Was this change in behavior deliberate? Is there some setting
> I can use to restore the old behavior? I was hoping to avoid having to
> compile my own, but if that's what is necessary to get back the old
> behavior, I will.
> >      >
> >      > This was a deliberate change as of 0.26, due to
> http://code.mythtv.org/trac/ticket/7994 .  The consistency argument is
> documented in the ticket description.
> >      >
> >      > If you want to change the behavior, look in
> TV::PrepareToExitPlayer().  You probably want to change the condition "if
> (bookmark_it)" to something like "if (bookmark_it &&
> !(ctx->player->IsNearEnd() || getEndOfRecording()))".
> >      >
> >      > Jim
> >
> >     Many thanks for the pointers, both the ticket and where to look to
> change the behavior.
> >
> >     I have to say I disagree with the consistency argument, at least
> with the way it's working with my settings in 0.23. I see a clear
> distinction between the user actively choosing to exit playback by pressing
> Escape, as opposed to passively exiting playback because the recording
> played to the end, and don't see why the bookmark should be cleared in the
> passive exit case.
> >
> >     I also feel that having it work the way it did in 0.23 is much more
> user friendly in a multi-person household where you don't want to clobber
> someone else's bookmark when you're able to watch a recording from
> beginning to end after they only found the time to watch part of the
> recording but want to resume where they left off.
> >
> >     Another advantage to the old way is, if you're an insomniac who
> finds it easier to fall asleep to the TV than to silence, it's pretty
> darned convenient to press OK after you skip a commercial, knowing that, if
> you do fall asleep, you'll be able to resume watching the show from where
> you were last awake.
> >
> > Looking closer, I think maybe the auto-clear-bookmark logic is a bit too
> liberal.  If "Clear bookmark on playback" is *unchecked* (which is true in
> your setup and not true in mine), perhaps the bookmark should be left alone
> at end-of-playback exit.
> >
> > Jim
>
> Thanks for giving more thought to this issue. Would you like me to open a
> ticket? If you decide to make a change and want me to test it, I'd be happy
> to. I'm sure you could do it more quickly and correctly than I could. Plus,
> I probably won't be able to work on it until after New Years.
>
> It seems that my observation about the "Clear bookmark on playback"
setting was actually pointed out by Mike Dean 4 years ago:
http://www.gossamer-threads.com/lists/mythtv/dev/420919#420919
Apparently I overlooked that...

In any case, I should be able to get that fixed pretty soon, but open a
ticket if I don't. :)

Jim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mythtv.org/pipermail/mythtv-users/attachments/20131219/a45e9288/attachment-0001.html>